Update parser.yml #1277
Open
Update parser.yml #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajout de deux champs dans le parsing pour permettre une détection plus fine et une qualification plus approfondie.
squioc
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Hello, Can you declare these two new fields into the taxonomy file and update the test?
$ cd utils
$ poetry run pytest test_formats.py --format crowdstrike_falcon
$ poetry run pytest test_formats.py --format crowdstrike_falcon --fix-expectations
Thank you.
Add off the two fields in tne Taxonomy file
|
@squioc I did the action. |
|
@FlIsec Can you update the tests? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajout de deux champs dans le parsing pour permettre une détection plus fine et une qualification plus approfondie.