Eva-Liisa JS Basic problem Set #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnfmnfm
reviewed
Nov 30, 2017
| @@ -21,3 +21,17 @@ | |||
| */ | |||
|
|
|||
| // YOUR CODE HERE | |||
|
|
|||
| function isPalindrome(str) { | |||
| var newStr = str.replace(/[^\w\s]/gi, '').replace(/ /g,'').toLowerCase(); //remove punctuation and spaces, convert to lowercas | |||
There was a problem hiding this comment.
I'm assuming this is good use of Googling, but even so, I'm glad you were able to get this working!
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
While this works, you could replace lines 32-36 with just return revString == newStr;, since if it's true you return true, and otherwise you return false. :)
| @@ -10,3 +10,30 @@ | |||
| */ | |||
|
|
|||
| // YOUR CODE HERE | |||
| function isPrime(num) { | |||
| if (num < 2) { | |||
There was a problem hiding this comment.
thank you for correctly handling the fact that 1 is not prime! 😁
| var primeArr = []; | ||
| var number = 2; | ||
|
|
||
| while (primeArr.length < max) { //loop runs until the length of the array of prime number is equal to max |
There was a problem hiding this comment.
Watch your indentation here--it'll be easier to debug your code if it's easier to read.
| var second_word = ["weather-bitten", "unchin-snouted", "toad-spotted", "tickle-brained", "tardy-gaited", "swag-bellied", "spur-galled", "sheep-biting", "shard-borne", "rump-fed", "rude-growing", "rough-hewn", "reeling-ripe", "pox-marked", "pottle-deep", "plume-plucked", "onion-eyed", "motley-minded", "milk-livered", "knotty-pated", "ill-nurtured", "ill-breeding", "idle-headed", "hell-hated", "hedge-born", "hasty-witted", "half-faced", "guts-griping", "full-gorged", "fool-born", "folly-fallen", "fly-bitten", "flap-mouthed", "fen-sucked", "fat-kidneyed", "elf-skinned", "earth-vexing", "dread-bolted", "doghearted", "dizzy-eyed", "dismal-dreaming", "crook-pated", "common-kissing", "clay-brained", "clapper-clawed", "boil-brained", "beetle-headed", "beef-witted", "bat-fowling", "base-court"]; | ||
| var third_word = ["wagtail", "whey-face", "vassal", "varlet", "strumpet", "skainsmate", "scut", "ratsbane", "pumpion", "puttock", "pignut", "pigeon-egg", "nut-hook", "mumble-news", "moldwarp", "miscreant", "minnow", "measle", "mammet", "malt-worm", "maggot-pie", "lout", "lewdster", "joithead", "hugger-mugger", "horn-beast", "hedge-pig", "harpy", "haggard", "gudgeon", "giglet", "fustilarian", "foot-licker", "flirt-gill", "flax-wench", "flap-dragon", "dewberry", "death-token", "codpiece", "coxcomb", "clotpole", "clack-dish", "canker-blossom", "bum-bailey", "bugbear", "boar-pig", "bladder", "barnacle", "baggage", "apple-john"]; | ||
| } |
There was a problem hiding this comment.
What is this curly brace? Where did it come from???
|
|
||
| // YOUR CODE HERE | ||
| function generateRandom(currentArr) { //passes the current array through the function and generates a random word from that array |
There was a problem hiding this comment.
Nice use of functions to do this repeated functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.