homework js-basics completed #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnfmnfm
reviewed
Nov 30, 2017
| let toStop = false; | ||
|
|
||
| while (!toStop) { | ||
| toStop = true; |
There was a problem hiding this comment.
This looks like it's very much based on the sorting code from yesterday, and the outer loop isn't necessary; it will only ever run once. So if you got rid of lines 28, 29, 30, 31, and 43, your code would run in exactly the same way.
| var p =[]; | ||
| function primes(max) { | ||
| for (var i = 2; i < max ; i++) { | ||
| if (isPrime(i) === true){ |
There was a problem hiding this comment.
Anytime you're checking if something === true, you can just check that thing! You could just say if(isPrime(i)).
| if (num % i === 0){ | ||
| return false | ||
| } | ||
| }; |
There was a problem hiding this comment.
Watch your indentation here; it'll be easier to debug your code when it's easier to read.
|
|
||
| var new_words = [randomItemFirst, randomItemSecond, randomItemThird]; | ||
|
|
||
|
|
There was a problem hiding this comment.
I wish that this had gotten to the stage of putting those words into the sentence together, but this is a good start!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completed this assignment with extra couple hours. Googled and asked friends' assistance. I will put more time to view it again. Thanks