ifstreamにわたす前に文字コードを変える処理を追加 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Windowsで、ユーザー名に日本語が含まれている場合にエラーになる問題を修正します。
文字コードを変換する関数を追加し、Windowsの場合は文字コードを変換してからifstreamにわたすようにしました。
関連 Issue
ref #1
その他
もしかしたら、open_jtalk側も修正が必要になるかもしれません。以前、voicevox_coreのWindows c++ exampleを作ったときにも同様の問題が発生しました。VOICEVOX#208最新では修正されているはずだから、最新を使うようにすればいいだけ？製品版のcore.dllを差し替えたら普通に起動しました。