Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpkneller version 2.0 #308

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from
Draft

Jpkneller version 2.0 #308

wants to merge 80 commits into from

Conversation

Sheshuk
Copy link
Contributor

@Sheshuk Sheshuk commented Mar 3, 2024

This is a draft PR with all the changes in one branch.
It will be easier to separate it into smaller PRs with orthogonal changes - and see how it plays along with other updates.

This PR is meant for bookkeeping and discussion - so it stays a draft, to overview all changes, until we make all features into separate PRs and merge them.

@Sheshuk Sheshuk added this to the v2.0 milestone Mar 3, 2024
Copy link
Contributor Author

@Sheshuk Sheshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked changed files by the categories, so we can make separate PRs:

  1. Flavor -> TwoFlavor, ThreeFlavor, FourFlavor
  2. FlavorTransformations: matrix
  3. SNOSHEWS
  4. EMEWS
  5. Update SNOwGLoBES interface
  6. Remove deprecated files
  7. Update usage examples

These changes can be merged incrementally, i.e. we can start with Flavors, and move to next points after the first one is merged.

@jpkneller would that plan make sense? Are these all changes, or did I miss anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deprecated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flavor->ThreeFlavor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Flavor-> TwoFlavor, ThreeFlavor, ForFlavor
  • Mixing matrix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove deprecated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • EMEWS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • EMEWS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • SNOSHEWS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • SNOSHEWS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNOSHEWS

@jpkneller
Copy link
Contributor

I marked changed files by the categories, so we can make separate PRs:

1. Flavor -> TwoFlavor, ThreeFlavor, FourFlavor

2. FlavorTransformations: matrix

3. SNOSHEWS

4. EMEWS

5. Update SNOwGLoBES interface

6. Remove deprecated files

7. Update usage examples

These changes can be merged incrementally, i.e. we can start with Flavors, and move to next points after the first one is merged.

@jpkneller would that plan make sense? Are these all changes, or did I miss anything?

I think you got everything. I agree with the order, the first two steps will generate the most issues.

@jpkneller jpkneller marked this pull request as ready for review March 4, 2024 16:17
@Sheshuk Sheshuk marked this pull request as draft March 4, 2024 18:54
Allows comparison of 'flavor' across schemes i.e. TwoFlavor.NU_X == ThreeFlavor.NU_MU returns True.
@Sheshuk Sheshuk mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants