-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jpkneller version 2.0 #308
base: main
Are you sure you want to change the base?
Conversation
Update flavor_transformation.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked changed files by the categories, so we can make separate PRs:
- Flavor -> TwoFlavor, ThreeFlavor, FourFlavor
- FlavorTransformations: matrix
- SNOSHEWS
- EMEWS
- Update SNOwGLoBES interface
- Remove deprecated files
- Update usage examples
These changes can be merged incrementally, i.e. we can start with Flavors, and move to next points after the first one is merged.
@jpkneller would that plan make sense? Are these all changes, or did I miss anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flavor->ThreeFlavor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Flavor-> TwoFlavor, ThreeFlavor, ForFlavor
- Mixing matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- EMEWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- EMEWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- SNOSHEWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- SNOSHEWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SNOSHEWS
I think you got everything. I agree with the order, the first two steps will generate the most issues. |
Allows comparison of 'flavor' across schemes i.e. TwoFlavor.NU_X == ThreeFlavor.NU_MU returns True.
added __hash__ and replaced to_tex methods
fixed import problem
Fixed - sign typo
Fix U re-ordering problem
This is a draft PR with all the changes in one branch.
It will be easier to separate it into smaller PRs with orthogonal changes - and see how it plays along with other updates.
This PR is meant for bookkeeping and discussion - so it stays a draft, to overview all changes, until we make all features into separate PRs and merge them.