#13156 Hide Case Classification for RSV and Automatically Set Default… #13164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13164 |
| @@ -2066,7 +2066,8 @@ private void updateTasksOnCaseChanged(Case newCase, CaseDataDto existingCase) { | |||
| @PermitAll | |||
| public void onCaseSampleChanged(Case associatedCase) { | |||
| // Update case classification if the feature is enabled | |||
| if (configFacade.getCaseClassificationCalculationMode(associatedCase.getDisease()).isAutomaticEnabled()) { | |||
| if (configFacade.getCaseClassificationCalculationMode(associatedCase.getDisease()).isAutomaticEnabled() | |||
| & associatedCase.getDisease() != Disease.RESPIRATORY_SYNCYTIAL_VIRUS) { | |||
There was a problem hiding this comment.
the above condition will be hard to follow if the number of diseases with this attributes start to grow. Shouldn't we have a single place where we test the disease?
There was a problem hiding this comment.
Can be changed when it gets hard to follow, at the moment we don't know how it will be
|
will this disease features be applied only on Luxembourg servers? |
For all servers |
sergiupacurariu
approved these changes
Oct 23, 2024
leventegal-she
deleted the
change-#13156-hide-case-classification-for-RSV
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Values
Fixes #13156