Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setup.sh for installation : Issue #129 Fixed #130

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SanyamGarg12
Copy link

Added setup.sh as an alternative of MakeFile and updated readme accordingly.

@SanyamGarg12
Copy link
Author

@NachtSpyder04

Copy link
Contributor

@NachtSpyder04 NachtSpyder04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have contributed to an already existing README.md. Make sure to inspect how headings and other information are in which format rather than copy-pasting your work without cross-checking.

Fix all your headings and other information in such a way that whole README looks like one single document maintained by one person.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@NachtSpyder04 NachtSpyder04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I test your script? you have not mentioned it in the description

Update your description for the same (a Dockerfile will be preferable)

setup.sh Outdated Show resolved Hide resolved
@NachtSpyder04
Copy link
Contributor

Update your PR title as well; it is unclear to those who are not aware of this issue.

@SanyamGarg12 SanyamGarg12 changed the title #129 issue : Fixed Added setup.sh for installation : Issue #129 Fixed Nov 4, 2024
@SanyamGarg12
Copy link
Author

SanyamGarg12 commented Nov 4, 2024

Hi @NachtSpyder04! Thank you for reviewing my fixes. This is my first contribution, so I wasn’t yet familiar with some of these basics. I've also updated the README, keeping the original format intact to maintain consistency.

To test the project setup, you can create a new virtual environment and run the bash script I added (no need to use make install). I've included instructions to guide you through the process.

I'm more than happy to help improve further—just let me know if there's anything else I can work on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants