krb5_child: ignore Smartcard identifiers with a ':' #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't it libkrb5 bug? |
|
Will this apply to sssd-2.9 cleanly? |
Hi, yes, worked for me. bye, |
Hi, I will open a ticket to make them aware, but I guess it is first an issue about documenting this limitation. bye, |
ikerexxe
reviewed
Dec 12, 2024
sumit-bose
force-pushed
the
krb5_child_pkcs11_ignore_colon
branch
from
0b72240 to
4ace271
Compare
|
A couple of minor comments inline. |
libkrb5 expects the Smartcard identifiers like token name or label in a single strings separated by ':'. If one of the identifiers contain a ':' this breaks and since libkrb5 currently does not support escaping of ':' SSSD will ignore the Smartcard during its pre-auth step to determine the available authentication methods and will error out if this happens during the actual authentication step. Resolves: SSSD#7746
sumit-bose
force-pushed
the
krb5_child_pkcs11_ignore_colon
branch
from
4ace271 to
cce39f5
Compare
|
Thank you, ACK. |
alexey-tikhonov
approved these changes
Dec 20, 2024
ikerexxe
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libkrb5 expects the Smartcard identifiers like token name or label in a
single strings separated by ':'. If one of the identifiers contain a ':'
this breaks and since libkrb5 currently does not support escaping of ':'
SSSD will ignore the Smartcard during its pre-auth step to determine
the available authentication methods and will error out if this happens
during the actual authentication step.
Resolves: #7746