Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa-lib: add Upstream-Status to the patches #52

Open
wants to merge 1 commit into
base: mickledore
Choose a base branch
from

Conversation

quaresmajose
Copy link
Contributor

@quaresmajose quaresmajose commented Jun 21, 2023

Fixing the build when using oe-core master branch:

ERROR: alsa-lib-1.2.9-r0 do_patch: QA Issue: Missing Upstream-Status in patch
/build-lmp-stm32mp15-disco-main-next/conf/../../layers/meta-st-stm32mp/recipes-bsp/alsa/alsa-lib/0001-conf-add-card-configs-for-stm32mp15x-boards.patch
Please add according to https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status . [patch-status]
ERROR: alsa-lib-1.2.9-r0 do_patch: QA Issue: Missing Upstream-Status in patch
/build-lmp-stm32mp15-disco-main-next/conf/../../layers/meta-st-stm32mp/recipes-bsp/alsa/alsa-lib/0002-conf-add-card-config-for-stm32mp13x_evd-board.patch
Please add according to https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status . [patch-status]
ERROR: alsa-lib-1.2.9-r0 do_patch: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /build-lmp-stm32mp15-disco-main-next/tmp-lmp/work/cortexa7t2hf-neon-vfpv4-lmp-linux-gnueabi/alsa-lib/1.2.9-r0/temp/log.do_patch.559211
ERROR: Task (/build-lmp-stm32mp15-disco-main-next/conf/../../layers/openembedded-core/meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb:do_patch) failed with exit code '1'

Fixing the build when using oe-core master branch:

| ERROR: alsa-lib-1.2.9-r0 do_patch: QA Issue: Missing Upstream-Status in patch
| /build-lmp-stm32mp15-disco-main-next/conf/../../layers/meta-st-stm32mp/recipes-bsp/alsa/alsa-lib/0001-conf-add-card-configs-for-stm32mp15x-boards.patch
| Please add according to https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status . [patch-status]
| ERROR: alsa-lib-1.2.9-r0 do_patch: QA Issue: Missing Upstream-Status in patch
| /build-lmp-stm32mp15-disco-main-next/conf/../../layers/meta-st-stm32mp/recipes-bsp/alsa/alsa-lib/0002-conf-add-card-config-for-stm32mp13x_evd-board.patch
| Please add according to https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status . [patch-status]
| ERROR: alsa-lib-1.2.9-r0 do_patch: Fatal QA errors were found, failing task.
| ERROR: Logfile of failure stored in: /build-lmp-stm32mp15-disco-main-next/tmp-lmp/work/cortexa7t2hf-neon-vfpv4-lmp-linux-gnueabi/alsa-lib/1.2.9-r0/temp/log.do_patch.559211
| ERROR: Task (/build-lmp-stm32mp15-disco-main-next/conf/../../layers/openembedded-core/meta/recipes-multimedia/alsa/alsa-lib_1.2.9.bb:do_patch) failed with exit code '1'

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose
Copy link
Contributor Author

Latest force push on mickledore branch broken the bitbake parsing.
So any other layer that uses mickledore branch of meta-st-stm32mp layer is now not usable:

Parsing recipes...
ERROR: /srv/oe/build/conf/../../layers/meta-st-stm32mp/recipes-st/images/st-image-bootfs-efi.bb: No IMAGE_CMD defined for IMAGE_FSTYPES entry 'vfat' - possibly invalid type name or missing support class
ERROR: Parsing halted due to errors, see error messages above

Possible fix for this can be:

--- a/recipes-st/images/st-image-bootfs-efi.bb
+++ b/recipes-st/images/st-image-bootfs-efi.bb
@@ -1,6 +1,8 @@
 SUMMARY = "STM32MP bootfs EFI Image"
 LICENSE = "MIT"
 
+inherit image_types-stfat
+
 include recipes-st/images/st-image-partitions.inc
 
 # Set ROOTFS_MAXSIZE to expected ROOTFS_SIZE to use the whole disk partition and leave extra space to user

@BernardPuel
Copy link
Contributor

Thanks for your contribution.
we will integrate the patch when a tag will be available (that is ST internal policy).

@IghuToh0
Copy link

Thanks for your contribution. we will integrate the patch when a tag will be available (that is ST internal policy).

Is there any public time line for tag releases or e. g. LTS plan?

@BernardPuel
Copy link
Contributor

OSTL V5.1 distribution is planned for June Y24: still with Mickledore
OSTL V6.0 distribution is planned for Nov Y24: with Scarthgap
OSTL V4.0 was delivered June Y22 so will be maintained till June Y24 (V4.1.2 delayed to July due to V5.1 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants