-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCTEAM-1338:Setting up a systemd service-article #315
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Amrita42 : Many thanks, well done! Sorry for the large number of comments and suggestions but the majority of them is about updating the metadata and adjusting some structures to the latest template updates (I provide those as suggestions).
PROFCONDITION="suse-product" | ||
PROFOS="generic" | ||
#PROFCONDITION="suse-product;beta" | ||
#PROFCONDITION="community-project" | ||
|
||
STYLEROOT="/usr/share/xml/docbook/stylesheet/suse2022-ns" | ||
FALLBACK_STYLEROOT="/usr/share/xml/docbook/stylesheet/suse-ns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PROFCONDITION="suse-product" | |
PROFOS="generic" | |
#PROFCONDITION="suse-product;beta" | |
#PROFCONDITION="community-project" | |
STYLEROOT="/usr/share/xml/docbook/stylesheet/suse2022-ns" | |
FALLBACK_STYLEROOT="/usr/share/xml/docbook/stylesheet/suse-ns" | |
## Profiling | |
PROFOS="PRODUCT" | |
#PROFCONDITION="PRODUCTNUMBER" | |
#STRUCTID="STRUCTURE-ID" | |
#PROFARCH="x86_64;zseries;power;aarch64" | |
DOCBOOK5_RNG_URI="urn:x-suse:rng:v2:geekodoc-flat" | |
STYLEROOT="/usr/share/xml/docbook/stylesheet/suse2022-ns" | |
FALLBACK_STYLEROOT="/usr/share/xml/docbook/stylesheet/suse-ns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to latest template
<merge> | ||
<title>Setting up a &systemd; service</title> | ||
<revhistory xml:id="rh-setting-up-systemd"> | ||
<revision><date>2024-03-20</date> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<revision><date>2024-03-20</date> | |
<revision><date>2024-11-27</date> |
<revision><date>2024-03-20</date> | ||
<revdescription> | ||
<para> | ||
Initial version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial version. | |
Initial version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without full stop as per example in the style guide, see https://documentation.suse.com/style/current/html/docu_styleguide/sec-smartdocs.html#sec-revhistory
<phrase>&power;</phrase> | ||
</meta> | ||
<meta name="productname" its:translate="no"> | ||
<!-- enter product name and version --><productname version="15-SP5">&sles;</productname> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- enter product name and version --><productname version="15-SP5">&sles;</productname> | |
<!-- enter product name and version --><productname version="15 SP6">&sles;</productname> |
<dm:docmanager xmlns:dm="urn:x-suse:ns:docmanager"> | ||
<dm:bugtracker> | ||
<dm:url>https://bugzilla.suse.com/enter_bug.cgi</dm:url> | ||
<dm:component>Smart Docs</dm:component> | ||
<dm:product>Documentation</dm:product> | ||
<dm:assignee>[email protected]</dm:assignee> | ||
</dm:bugtracker> | ||
<dm:translation>yes</dm:translation> | ||
</dm:docmanager> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dm:docmanager xmlns:dm="urn:x-suse:ns:docmanager"> | |
<dm:bugtracker> | |
<dm:url>https://bugzilla.suse.com/enter_bug.cgi</dm:url> | |
<dm:component>Smart Docs</dm:component> | |
<dm:product>Documentation</dm:product> | |
<dm:assignee>[email protected]</dm:assignee> | |
</dm:bugtracker> | |
<dm:translation>yes</dm:translation> | |
</dm:docmanager> | |
<dm:docmanager xmlns:dm="urn:x-suse:ns:docmanager"> | |
<dm:bugtracker> | |
<dm:url>https://bugzilla.suse.com/enter_bug.cgi</dm:url> | |
<dm:product>SUSE Linux Enterprise Server 16.0</dm:product> | |
<dm:component>Documentation</dm:component> | |
<dm:assignee>[email protected]</dm:assignee> | |
</dm:bugtracker> | |
<dm:translation>yes</dm:translation> | |
</dm:docmanager> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the latest template for Bugzilla pointers (see https://github.com/openSUSE/doc-kit/blob/main/smart-doc/articles/assembly.asm.xml#L111 for reference)
</listitem> | ||
</varlistentry> | ||
</variablelist> | ||
<para>The <command>sysctemctl edit </command> command by default opens a unit file snippet, for example:</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<para>The <command>sysctemctl edit </command> command by default opens a unit file snippet, for example:</para> | |
<para>The <command>systemctl edit </command> command by default opens a unit file snippet, for example:</para> |
xmlns:xi="http://www.w3.org/2001/XInclude" | ||
xmlns:xlink="http://www.w3.org/1999/xlink" | ||
xmlns:trans="http://docbook.org/ns/transclusion"> | ||
<info> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content-wise, most of this file is indeed a reference (even if it includes some instructions, which means that the reference purpose is mixed up a bit). However, the title suggests otherwise - as a reader, under the headline 'Editing foo bar' I would have expected tasks and step-by-step procedures.
I leave it up to you how to handle that. From my perspective, you could:
- Rewrite the topic to a task (and keep the title). In that case you could probably split the topic up into the following procedures
- Adding directives and overriding files
- Customizing existing unit files completely
- Removing custom changes to unit file
- Keep the topic as a reference but adjust the title so if reflects what to expect (maybe rephrase to something like 'The sysctemctl edit command')
<term><filename>/usr/lib/systemd/system/</filename></term> | ||
<listitem> | ||
<para> | ||
When the package is installed, &systemd; unit files reside here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the package? which one? the systemd package?
</abstract> | ||
</info> | ||
<para>There are three main directories where unit files are stored on the system: </para> | ||
<variablelist> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe already mention here which directory takes precedence in case two 'versions' of one file exist.
<screen>&prompt.root;<command>systemctl</command> start apache2 | ||
Job for apache2.service failed because the control process exited with error code. | ||
See "systemctl status apache2.service" and "journalctl -xe" for details.</screen> | ||
<itemizedlist> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's a personal preference of mine, but I would use a variabelist here (instead of an itemizedlist with listitems). That way, you could highlight the 'goal' for each debug action in the variablelist title (you could mostly use as titles what you now have as first para of each listitem). That makes it easier for the readers to skim through the titles to find the debug action they are interested in.
Description
The scope of this PR is to cover the scope of "Setting up a systemd service" as defined in https://jira.suse.com/browse/DOCTEAM-1338
Reviewers
Please dont review now , will tag in slack when ready.
Reused (Review not required as this topics have been reviewed and are being re-used multiple times)
Review required