Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in SUMA integration #186

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

abravosuse
Copy link
Collaborator

This PR must be reviewed but cannot be merged/published until the new version of Trento is out. It describes the second iteration of the integration of Trento with SUSE Manager, by which we can see the list of available patches and upgradable packages for each registered host that is also managed by SUMA.

PR creator: Description

Describe the overall goals of this pull request.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#SLE-...

@abravosuse abravosuse added the prj:Trento Related to Trento documentation label Oct 25, 2024
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abravosuse Some small issues and a missing image. 🙂

trento/xml/article_sap_trento.xml Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
@tomschr tomschr force-pushed the abravosuse-changes-in-suma-integration branch from 7da187c to 53d630c Compare November 4, 2024 10:28
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomschr missing file uploaded. All other suggestions accepted AS-IS. Thank you!

Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Comment on lines +1797 to +1802
<para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview,
where the user can see the list of packages that can be upgraded in that particular host:</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview,
where the user can see the list of packages that can be upgraded in that particular host:</para>
<para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Package</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview,
where the user can see the list of packages that can be upgraded in that particular host:</para>
<para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Packages</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para>>

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions @dmpop . Just a small change request from my side: Upgradable Package > Upgradable Packages.

Comment on lines +1797 to +1802
<para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview,
where the user can see the list of packages that can be upgraded in that particular host:</para>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview,
where the user can see the list of packages that can be upgraded in that particular host:</para>
<para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Packages</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para>>

abravosuse and others added 20 commits November 15, 2024 13:13
This PR must be reviewed but cannot be merged/published until the new version of Trento is out.
It describes the second iteration of the integration of Trento with SUSE Manager, by which we can see the list of available patches and  upgradable packages for each registered host that is also managed by SUMA.
@tomschr tomschr force-pushed the abravosuse-changes-in-suma-integration branch from b1a02af to 3f70572 Compare November 15, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prj:Trento Related to Trento documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants