Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Commit

Permalink
Stop using sourceLocationTracking (useless with webpack + typescript)
Browse files Browse the repository at this point in the history
  • Loading branch information
dcermak committed Apr 8, 2021
1 parent 9642b64 commit 74de39b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions src/logging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ export const getGlobalLogger = (): IVSCodeExtLogger | undefined => logger;
* function of the extension.
*
* @param debugMode When `true`, then the created logger's logging level is set
* to `trace` and source location tracking and logging to console is
* enabled.
* Otherwise, the later two options are kept at the default and the logging
* to `trace` and logging to console is enabled.
* Otherwise, logging to console is kept at the default and the logging
* level is taken from [[CONFIGURATION_LOG_LEVEL]].
*
* @param getExtensionLoggerFunc The function that returns the logger (only
Expand Down Expand Up @@ -101,7 +100,6 @@ export function setupLogger(
.get<LogLevel>(CONFIGURATION_LOG_LEVEL, DEFAULT_LOG_LEVEL)
};
if (debugMode) {
options.sourceLocationTracking = true;
options.logConsole = true;
}
logger = getExtensionLoggerFunc(options);
Expand Down
3 changes: 1 addition & 2 deletions src/test/suite/logging.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ describe("logging", () => {
options.should.deep.include({
logPath: this.fixture.fakeContext.logUri.fsPath,
level: "trace",
logConsole: true,
sourceLocationTracking: true
logConsole: true
});
})
);
Expand Down

0 comments on commit 74de39b

Please sign in to comment.