Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Podman instead of Docker for Selenium test #288

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Aug 1, 2023

This PR:

  • Uses Podman instead of Docker for the Selenium test.
  • Fixes the cleanup code to remove the image afterwards.

Because this test builds a Docker image it may take some time if the layers aren't cached. Set the SKIP_SELENIUM environment variable when running pytest or make test.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a413fb) 78.56% compared to head (b4a50d8) 78.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          21       21           
  Lines        1549     1549           
=======================================
  Hits         1217     1217           
  Misses        332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmorodskyi asmorodskyi merged commit 6985c16 into SUSE:master Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants