Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gce: Improve logging for routes cleanup #292

Closed
wants to merge 3 commits into from

Conversation

asmorodskyi
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.14% ⚠️

Comparison is base (a0ac689) 79.17% compared to head (fc832de) 79.03%.
Report is 6 commits behind head on master.

❗ Current head fc832de differs from pull request most recent head 4efa4d6. Consider uploading reports for the commit 4efa4d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   79.17%   79.03%   -0.14%     
==========================================
  Files          21       21              
  Lines        1594     1593       -1     
==========================================
- Hits         1262     1259       -3     
- Misses        332      334       +2     
Files Changed Coverage Δ
ocw/lib/gce.py 91.48% <57.14%> (-1.47%) ⬇️
ocw/lib/aks.py 95.23% <100.00%> (ø)
ocw/lib/eks.py 85.61% <100.00%> (ø)
ocw/lib/gke.py 58.33% <100.00%> (ø)
ocw/lib/k8s.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pdostal
pdostal previously approved these changes Aug 6, 2023
Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants