Deploy valid AWS images past their DeprecationTime

TEAM-8177 - [AWS][Terraform] qe-sap-deployment cannot deploy valid images past their DeprecationTime
SUSE · Aug 25, 2023 · 3e35b98 · 3e35b98
1 parent 7b337b8
commit 3e35b98
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/terraform/aws/modules/get_os_image/main.tf b/terraform/aws/modules/get_os_image/main.tf
@@ -1,11 +1,12 @@
 # Data used to get the correct AMI image
 data "aws_ami" "image" {
-  most_recent = true
-  owners      = [var.os_owner]
+  most_recent        = true
+  owners             = [var.os_owner]
+  include_deprecated = true
 
   filter {
     name   = "name"
-    values = substr(var.os_image, 0, 4) == "ami-" ? ["*"] : ["${var.os_image}-*"]
+    values = substr(var.os_image, 0, 4) == "ami-" ? ["*"] : ["${var.os_image}*"]
   }
 
   filter {
@@ -22,4 +23,9 @@ data "aws_ami" "image" {
     name   = "virtualization-type"
     values = ["hvm"]
   }
+
+  filter {
+    name   = "state"
+    values = ["available"]
+  }
 }
diff --git a/terraform/aws/version.tf b/terraform/aws/version.tf
@@ -4,7 +4,7 @@ terraform {
     # Configure the Azure Provider
     aws = {
       source  = "hashicorp/aws"
-      version = "~> 4.0.0"
+      version = "~> 5.13.1"
     }
     null = {
       source  = "hashicorp/null"

diff --git a/terraform/gcp/variables.tf b/terraform/gcp/variables.tf
@@ -81,7 +81,7 @@ variable "deployment_name" {
   default     = ""
   validation {
     condition = (
-      var.deployment_name != "default" && var.deployment_name != ""
+      var.deployment_name != "default"
     )
     error_message = "Invalid deployment_name (default) ."
   }