Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more Salt provisioning code #179

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove more Salt provisioning code #179

merged 1 commit into from
Oct 3, 2023

Conversation

mpagot
Copy link
Collaborator

@mpagot mpagot commented Oct 2, 2023 •
edited
Loading

Remove Salt, bastion and offline_mode related code

VR

@mpagot mpagot temporarily deployed to production October 2, 2023 07:29 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:29 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:29 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:29 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:35 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:35 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:35 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:35 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:55 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:55 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:55 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 07:55 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:01 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:01 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:01 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:01 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:05 — with GitHub Actions Inactive
@mpagot
Remove more Salt provisioning and bastion code
fc94b97 
Remove terraform code about Salt as the project is using Ansible
Remove more bastion code
Remove offline_mode
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
@mpagot mpagot temporarily deployed to production October 2, 2023 08:20 — with GitHub Actions Inactive
alvarocarvajald
alvarocarvajald reviewed Oct 2, 2023
View reviewed changes
terraform/azure/terraform.tfvars.example
@@ -1,5 +1,5 @@
#################################
# ha-sap-terraform-deployments project configuration file
# qe-sa-deployment project configuration file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. This was still there?! 😄

alvarocarvajald
alvarocarvajald approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpalovsky
lpalovsky approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpalovsky lpalovsky merged commit e56ad98 into SUSE:main Oct 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpalovsky lpalovsky lpalovsky approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpagot @alvarocarvajald @lpalovsky