Validate Terraform 1.5.7 and add tool validation pipeline #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
c7e3d8e
to
44b270a
Compare
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
44b270a
to
e6fbc38
Compare
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
e6fbc38
to
0716213
Compare
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
99907d4
to
9b7f354
Compare
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
9b7f354
to
4f70b41
Compare
Improve the Dockerfile to use Terraform 1.5.7 and Python 3.11. Add virtual env in the Dockerfile to fix a bug that prevented pip installation of python packages. Add bash script to validate the docker image. Add githubaction to build the container image and run the validation test.
mpagot
force-pushed
the
qesap_terraform1.5.7
branch
from
4f70b41
to
28295ca
Compare
mpagot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit description
Improve the Dockerfile to use Terraform 1.5.7 and Python 3.11.
Add virtual env in the Dockerfile to fix a bug that prevented pip installation of python packages.
Add bash script to validate the docker image.
Add githubaction to build the container image and run the validation
test.
Context
These project needs some tools to be pre-installed on the JumpHost to perform the deployment. Two of them are Python and Terraform. There's no way for the project to have control over what is installed, so tools version for these two are only suggested in the project main readme.
Dockerfile is not the main way this deployment is used, openQA is not running the
qe-sap-deploymentcode from within a container.PR purpose
This PR is about:
qe-sap-deployment...Pro n Cons
If something fails during the execution of the new pipeline is not so easy to understand what was wrong
The new pipeline could fails due to external issues, the Dockerfile are installing stuff from the web
Ticket
TEAM-9050
Verification
VR is the PR pipeline, took to the one named
toolshttps://github.com/SUSE/qe-sap-deployment/actions/runs/7822845007/job/21342714076?pr=208