Use smaller disks by default for tests on Azure #272
Conversation
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
force-pushed
the
azure-smaller-disks
branch
from
32e9658
to
8dc8f3a
Compare
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
force-pushed
the
azure-smaller-disks
branch
from
8dc8f3a
to
e31e6f7
Compare
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
force-pushed
the
azure-smaller-disks
branch
from
e31e6f7
to
c98da42
Compare
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
| @@ -212,7 +212,7 @@ variable "hana_data_disks_configuration" { | |||
| type = map(any) | |||
| default = { | |||
| disks_type = "Premium_LRS,Premium_LRS,Premium_LRS,Premium_LRS,Premium_LRS,Premium_LRS,Premium_LRS" | |||
| disks_size = "128,128,128,128,128,128,128" | |||
| disks_size = "32,32,16,16,32,64,32" | |||
There was a problem hiding this comment.
Maybe we can add a comment in the code to say something like
This default is aligned to default for hana_vm_size
We can also update comment in line 197 to talk about Standard_E4s_v3 and not Standard_M32ls
There was a problem hiding this comment.
Each value now is using a different number: does it make sense to document why and which disk has which size? Where we should do it? Here in this file or in the readme?
There's an explanation here
qe-sap-deployment/terraform/azure/README.md
Line 163 in 9f4aa9c
There was a problem hiding this comment.
I think those disks sizes are not finalized. I'll collect some data about cost saving with this commit. Then there shall be a follow up ticket to optimize the disk sizes further. Then we can add definitive documentation about disk sizes.
|
We should update and expand documentation in qe-sap-deployment/terraform/azure/README.md Line 209 in 9f4aa9c qe-sap-deployment/terraform/azure/README.md Line 224 in 9f4aa9c |
|
Good idea, I should keep the code and documentation in sync. |
|
Additional qesap regression VRs: https://openqaworker15.qa.suse.cz/tests/297047 |
zhaocongjia
force-pushed
the
azure-smaller-disks
branch
from
c98da42
to
189e8df
Compare
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
zhaocongjia
temporarily deployed
to
production
GitHub Actions
Inactive
Uses smaller disks for hanasr tests. Tests do not break. And test run time remains similar.
https://jira.suse.com/browse/TEAM-9625
VRs:
15SP5 BYOS spn:
https://openqa.suse.de/tests/15326917
https://openqa.suse.de/tests/15326918
https://openqa.suse.de/tests/15326920
https://openqa.suse.de/tests/15327230
15SP6 BYOS:
https://openqa.suse.de/tests/15375352
15SP5 BYOS msi:
https://openqa.suse.de/tests/15375353
15SP4 PAYG:
https://openqa.suse.de/tests/15375354
12SP5 PAYG msi:
https://openqa.suse.de/tests/15375355