Skip to content

Commit

Permalink
Remove unused credentials from config
Browse files Browse the repository at this point in the history
  • Loading branch information
m-roberts committed Jan 18, 2020
1 parent 2557e16 commit 1a29b21
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 27 deletions.
4 changes: 0 additions & 4 deletions MMM-Fitbit2.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ Module.register("MMM-Fitbit2",{

// Default module config.
defaults: {
credentials: {
client_id: "",
client_secret: ""
},
resources: [
"steps",
"caloriesOut",
Expand Down
40 changes: 17 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Setup
* (If you're asked for `OAuth 1.0 Application Type (Deprecated)`, set to "Browser")
* Callback URL **MUST BE** `http://127.0.0.1:8888/`
* Give your app read-only permission
* Note your OAuth 2.0 credentials (you'll need them in a moment!)
* Note your OAuth 2.0 credentials (you'll need them during setup)
* "OAuth 2.0 Client ID" --- (this is your `client_id`)
* "Client (Consumer) Secret" --- (this is your `client_secret`)
* You can access these again later via [Manage My Apps](https://dev.fitbit.com/apps)
Expand Down Expand Up @@ -71,33 +71,27 @@ Configuration
After installing MMM-Fitbit2, you will need to include the module in your MagicMirror configuration.

Add the example config below to your config file in `~/MagicMirror/config/config.json` (or whatever your path to your Magic Mirror config is).
**Note: make sure that you change the `client_id` and `client_secret` fields in the `credentials` object to your own**.

````javascript
{
module: "MMM-Fitbit2",
position: "top_center",
config: {
credentials: {
client_id: "<client_id>",
client_secret: "<client_secret>",
},
{
module: "MMM-Fitbit2",
position: "top_center",
config: {
resources: [
"steps",
"caloriesOut",
"distance",
"activeMinutes",
"floors",
"restingHeart",
"water",
"caloriesIn",
"sleep",
"weight"

"steps",
"caloriesOut",
"distance",
"activeMinutes",
"floors",
"restingHeart",
"water",
"caloriesIn",
"sleep",
"weight"
],
update_interval: 10
}
},
}
},

````

Expand Down
1 change: 1 addition & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ TODO
* Add more config parameters for controlling the view
* Add "Configuration Options" to README
* Add tests
* Add support for multiple users

## Low priority
* Regional formatting options
Expand Down

0 comments on commit 1a29b21

Please sign in to comment.