Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): migrate the OC Angular app to Vite (ARCH-337) #2922

Merged

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Nov 24, 2024

Closes https://sagebionetworks.jira.com/browse/ARCH-337

Changelog

  • Generate a new Angular app project configured to use Vite, update it and then replace the existing app project.
  • Specify stylePreprocessorOptions in project.json to reduce the location where the bundle can find styles.
  • Remove the sub-folder lib from the project openchallenges-styles and openchallenges-themes.
  • Update the paths to styles and themes files after setting stylePreprocessorOptions and refactoring the styles and themes projects.
  • Adapt the Dockerfile to the Vite build output.
  • Remove custom code previously added to server.ts to inject the server port when using the Express server.
  • Remove Tailwind CSS from the project sandbox-angular-app.
  • Adapt model-ad-app:build to changes made to the shared styles.

Copy link
Contributor

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested!

@tschaffter tschaffter merged commit 5b9a29f into Sage-Bionetworks:main Nov 25, 2024
14 of 15 checks passed
@tschaffter tschaffter deleted the sage-monorepo/angular-app-vite branch November 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants