Fix sort products issue

[eslamoo]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour? (You can also link to the ticket here)

Does this PR introduce a breaking change?

Screenshots (If appropriate)

[codacy-production]

Codacy found an issue: Useless identity escapes with non-syntax characters are forbidden.

[codacy-production]

Codacy found an issue: Assignment to href can be unsafe

[codacy-production]

Codacy found an issue: You have a misspelled word: salla on Identifier

[codacy-production]

❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on String

The code you provided has a misspelled word in the string. The correct spelling should be "sala" instead of "salla". To fix it, you need to update the code to use the correct spelling. Here's the corrected code:

Suggested change

	app.element('salla-products-list').setAttribute('filters', `{"sort": "${event.currentTarget.value}"}`)
	app.element('sala-products-list').setAttribute('filters', `{"sort": "${event.currentTarget.value}"}`);

Please note that I have replaced "salla" with "sala" in the code.

---

This comment was generated by an experimental AI tool.

[codacy-production]

Codacy found an issue: Assignment to src can be unsafe

[codacy-production]

❌ Codacy found a critical Error Prone issue: Async functions are not supported yet on Node 4.0.0.

The issue with the code is that it uses the await keyword inside a non-async function. Since the function is not declared as async, the use of await is not valid and will result in a syntax error.

To fix this issue, you can either declare the function as async or use a .then() method to handle the asynchronous operation.

Here's the updated code:

// Set Sort
if (urlParams.has('sort')) {
    app.element('#product-filter').value = urlParams.get('sort');
}

// Sort Products
app.on('change','#product-filter', event =>{
    window.history.replaceState(null, null, salla.helpers.addParamToUrl('sort',event.currentTarget.value));
    app.element('salla-products-list').sortBy=event.currentTarget.value;
    app.element('salla-products-list').reload()
        .then(() => {
            app.element('salla-products-list').setAttribute('filters', `{"sort": "${event.currentTarget.value}"}`);
        });
});

salla.event.once('salla-products-list::products.fetched', res=>{
    res.title && (app.element('#page-main-title').innerHTML = res.title);
});

this.initiateMobileMenu();

Note: This code assumes that reload() method returns a Promise. If it doesn't, you may need to modify the code accordingly.

---

This comment was generated by an experimental AI tool.

[codacy-production]

Codacy found an issue: The function Function can be unsafe

[codacy-production]

❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on Identifier

The issue with the code is that the identifier "salla" is misspelled. It should be "Salla" instead. To fix this, you need to change "salla.helpers.addParamToUrl" to "Salla.helpers.addParamToUrl" in the code.

Suggested change

	window.history.replaceState(null, null, salla.helpers.addParamToUrl('sort',event.currentTarget.value));
	window.history.replaceState(null, null, Salla.helpers.addParamToUrl('sort', event.currentTarget.value));

---

This comment was generated by an experimental AI tool.

[codacy-production]

Codacy found an issue: 'Symbol.toStringTag' is not supported yet on Node 4.0.0.

[codacy-production]

Codacy found an issue: Unencoded input 'e' used in HTML context

[codacy-production]

Codacy found an issue: The function setTimeout can be unsafe

[codacy-production]

❌ Codacy found a critical Error Prone issue: You have a misspelled word: salla on String

Suggested change

	await app.element('salla-products-list').reload();
	await app.element('salla-products-list').reload();
	```

Issue description: The code has a misspelled word "salla" in the string. It should be corrected to "salla-products-list".

---

This comment was generated by an experimental AI tool.

[codacy-production]

Codacy found an issue: The 'URLSearchParams' is not supported until Node.js 10.0.0. The configured version range is '>=8.0.0'.

[codacy-production]

Codacy found an issue: The function addEventListener can be unsafe

[codacy-production]

Codacy found an issue: Generic Object Injection Sink

[codacy-production]

Codacy found an issue: Unsafe assignment to innerHTML (Variable 'e' declared as function parameter, which is considered unsafe. 'FunctionExpression' at 2:10409)

[codacy-production]

❌ Codacy found a critical Error Prone issue: Async functions are not supported yet on Node 4.0.0.

The issue with the code is that it uses an async function, which is not supported in Node 4.0.0. To fix this, you can use a regular function instead of an async function. Here's the updated code:

Suggested change

	app.on('change','#product-filter', async event =>{
	app.on('change','#product-filter', function(event){
	window.history.replaceState(null, null, salla.helpers.addParamToUrl('sort',event.currentTarget.value));
	app.element('salla-products-list').sortBy=event.currentTarget.value;
	app.element('salla-products-list').reload().then(() => {
	app.element('salla-products-list').setAttribute('filters', `{"sort": "${event.currentTarget.value}"}`);
	});
	});

Note: This code suggestion assumes that the reload() method returns a promise. If it doesn't, you may need to modify the code accordingly.

---

This comment was generated by an experimental AI tool.

[codacy-production]

Codacy found an issue: localStorage can be unsafe