Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(themes): Support loyalty program #448

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

feat(themes): Support loyalty program #448

wants to merge 45 commits into from

Conversation

maalfaifi
Copy link
Collaborator

@maalfaifi maalfaifi commented Aug 19, 2024 •
edited by naderm91
Loading

No description provided.

@SallaDev SallaDev marked this pull request as draft August 19, 2024 18:10
@naderm91 naderm91 marked this pull request as ready for review August 29, 2024 13:13
@naderm91 naderm91 marked this pull request as draft August 29, 2024 13:13
@maalfaifi maalfaifi changed the title feat(themes): Support loyalty program (for test only) feat(themes): Support loyalty program Oct 3, 2024
@maalfaifi
Merge branch 'master' into feature/DAM-5606-fe-loyalty-new-points
79a01ef 
# Conflicts:
#	public/app.css
#	public/app.js
#	public/main-menu.js
#	public/product-card.js
@maalfaifi
Update app.css
1b15796
@naderm91 naderm91 marked this pull request as ready for review October 30, 2024 08:18
jalmatari
jalmatari requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jalmatari jalmatari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the reviews and make sure to avoid these changes,
public/*.js (except pages.js it should be affected)

src/views/layouts/master.twig Outdated Show resolved Hide resolved
src/views/pages/cart.twig Outdated Show resolved Hide resolved
src/views/pages/loyalty.twig Outdated Show resolved Hide resolved
src/views/pages/product/single.twig Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalmatari jalmatari Awaiting requested review from jalmatari

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maalfaifi @jalmatari @eslamoo @naderm91