Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recruitment overview page #1123

Merged
merged 18 commits into from
Jun 26, 2024
Merged

Recruitment overview page #1123

merged 18 commits into from
Jun 26, 2024

Conversation

Snorre98
Copy link
Contributor

@Snorre98 Snorre98 commented May 12, 2024 •
edited
Loading

This page is designed to replace the overview page and the statistics page at Samf3.
The overview page is a combination of this samf3 page and this samf3 page.

Recruitment progression

image

Recruitment progression - all processed:

image

Recruitment statistics page (no chart components)

image

@Snorre98 Snorre98 linked an issue May 12, 2024 that may be closed by this pull request
Skeleton for recruitment overview page #1097
Closed
@Snorre98 Snorre98 self-assigned this May 16, 2024
@Snorre98 Snorre98 requested review from Frenje123 and aTrueYety May 19, 2024 13:13
@Snorre98 Snorre98 marked this pull request as ready for review May 19, 2024 13:13
@Snorre98 Snorre98 requested a review from robines as a code owner May 19, 2024 13:13
@Snorre98 Snorre98 changed the title Rough draft recruitment overview page Recruitment overview page May 21, 2024
@Snorre98 Snorre98 requested a review from magsyg June 7, 2024 20:02
magsyg
magsyg approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@magsyg magsyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt ser ganske aight ut, og godt til å bygges på
Godkjenner, men lag først issues på å ha backendendepunkter og dtos for dataen som vises.

frontend/src/PagesAdmin/RecruitmentGangOverviewPage/RecruitmentGangOverviewPage.tsx Outdated Show resolved Hide resolved
...esAdmin/RecruitmentOverviewPage/Components/RecruitmentProgression/RecruitmentProgression.tsx Show resolved Hide resolved
...esAdmin/RecruitmentOverviewPage/Components/RecruitmentProgression/RecruitmentProgression.tsx Show resolved Hide resolved
...esAdmin/RecruitmentOverviewPage/Components/RecruitmentProgression/RecruitmentProgression.tsx Show resolved Hide resolved
...agesAdmin/RecruitmentOverviewPage/Components/RecruitmentStatistics/RecruitmentStatistics.tsx Show resolved Hide resolved
frontend/src/PagesAdmin/RecruitmentOverviewPage/RecruitmentOverviewPage.tsx Show resolved Hide resolved
hei98
hei98 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@hei98 hei98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut! Men kunne du lagt til en divider mellom disse i stedet for å ha de i to divs (to bokser)?
image

@Snorre98 Snorre98 mentioned this pull request Jun 23, 2024
Open
@Snorre98 Snorre98 requested a review from robines June 23, 2024 19:30
robines
robines requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@robines robines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se kommentarer

frontend/src/i18n/translations.ts Outdated Show resolved Hide resolved
...agesAdmin/RecruitmentOverviewPage/Components/RecruitmentStatistics/RecruitmentStatistics.tsx Outdated Show resolved Hide resolved
...agesAdmin/RecruitmentOverviewPage/Components/RecruitmentStatistics/RecruitmentStatistics.tsx Outdated Show resolved Hide resolved
@Snorre98 Snorre98 merged commit 493f586 into master Jun 26, 2024
5 checks passed
@Snorre98 Snorre98 deleted the 1097-skeleton-for-recruitment-overview-page branch June 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magsyg magsyg magsyg approved these changes

@hei98 hei98 hei98 approved these changes

@robines robines robines approved these changes

@Frenje123 Frenje123 Awaiting requested review from Frenje123

@aTrueYety aTrueYety Awaiting requested review from aTrueYety

Assignees

@Snorre98 Snorre98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skeleton for recruitment overview page
4 participants
@Snorre98 @robines @magsyg @hei98