Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory confirmation of occupied timeslots #1544

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

amaliejvik
Copy link
Contributor

  • Applicant must confirm his/her occupied timeslots in order to send an application for a position
  • OccupiedFormModal pops up when clicking the "Send søknad" button
image

Related to #1480
Closes #1480

…rder to send an application for a position

Related to #1480
@amaliejvik amaliejvik added the frontend Task related to frontend. label Oct 24, 2024
@amaliejvik amaliejvik self-assigned this Oct 24, 2024
@amaliejvik amaliejvik linked an issue Oct 24, 2024 that may be closed by this pull request
Related to #1480
@amaliejvik amaliejvik marked this pull request as draft October 29, 2024 20:16
@amaliejvik
Copy link
Contributor Author

amaliejvik commented Oct 29, 2024

Oppdaget at dette kun fungerer for søknader som allerede eksisterer (laget fra seedingen). Står bare og laster når man skal lage en ny søknad.. :( Fordi den prøver å hente recruitmentID fra getRecruitmentApplicationForPosition, for en application som ikke eksisterer enda. Skal se nærmere på dette, endret til draft igjen enn så lenge

UPDATE: This is fixed in the last commit 🥳

…ead of getRecruitmentApplicationForPosition, such that mandatory occupied time field also pops up when recruitmentapplication does not exist yet (a new application)

Related to #1480
@amaliejvik amaliejvik marked this pull request as ready for review October 31, 2024 18:52
Copy link
Contributor

@emsoraffa emsoraffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut, la inn noen små ting, bare å resolve når fiksa

frontend/src/Components/OccupiedForm/OccupiedForm.tsx Outdated Show resolved Hide resolved
frontend/src/Components/OccupiedForm/OccupiedForm.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Task related to frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory occupied time field
2 participants