Make status display actually human-readable statuses #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d rejected, called and accepted ...) instead of is's(0,1,2,3) in both RecruitmentGangAllApplicantsAdminPage and in RecruitmentPositionOverviewPage with translations Related to #1431
amaliejvik
added
bug
robines
requested changes
Nov 1, 2024
| @@ -84,6 +84,19 @@ export function RecruitmentGangAllApplicantsAdminPage() { | |||
| { content: t(KEY.recruitment_recruiter_status), sortable: true }, | |||
| ]; | |||
|
|
|||
| const getStatusOption = (id: number | undefined): string => { | |||
There was a problem hiding this comment.
Gjerne flytt til en egen globalt tilgjengelig funksjon/hook. Og bruk RecruitmentStatusChoices konstantene istedenfor tall
There was a problem hiding this comment.
Til det siste; kan være verdt å vite at det finnes et issue på å hente choices fra backend og implementere de for dette formålet: #1575
There was a problem hiding this comment.
bruker RecruitmentStatusChoices nå:) @robines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecruitmentGangAllApplicantsAdminPage:
RecruitmentPositionOverviewPage:
Før:
Etter:
Related to #1431
Closes #1431