1481 implement similar positions on recruitmentapplicationformpage #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for applicant serializer
Mathias-a
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Kan kanskje være litt forvirrende om navn og tags ikke stemmer? Ikke så farlig for meg assa
Comment on lines
+1360
to
+1361
| recruitment_id = self.kwargs.get('id') | ||
| tags_param = self.request.query_params.get('tags') |
There was a problem hiding this comment.
Funker det ikke å bruke getlist her?
Comment on lines
611
to
612
| } as const; No newline at end of file | ||
| } as const; |
Comment on lines
+178
to
+201
| {recruitmentPositionsForGang && recruitmentPositionsForGang.length > 0 && ( | ||
| <div className={styles.other_positions}> | ||
| <h2 className={styles.sub_header}> | ||
| {t(KEY.recruitment_otherpositions)} {dbT(recruitmentPosition?.gang, 'name')} | ||
| </h2> | ||
| {recruitmentPositionsForGang.map((pos) => ( | ||
| <Button | ||
| key={pos.id} | ||
| display="pill" | ||
| theme="outlined" | ||
| onClick={() => { | ||
| navigate({ | ||
| url: reverse({ | ||
| pattern: ROUTES.frontend.recruitment_application, | ||
| urlParams: { positionId: pos.id, gangId: pos.gang.id }, | ||
| }), | ||
| }); | ||
| }} | ||
| > | ||
| {dbT(pos, 'name')} | ||
| </Button> | ||
| ))} | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Dette kan flyttes ut i en konstant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Created backend and frontend for fetching positions from tags. This makes it possible to fetch positions similar to each other.
Modified seed script to create more realisitc tags.
Fixes some rendering issues on RecruitmentApplicationFromPage
Bette styling will be done in another PR. The entire page should get a glow-up.
Why
Fetching similar positions is a feature on Samf3
closes #1481