change recruitment status and priority to be fetched from backend #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snorre98
previously approved these changes
Nov 7, 2024
Comment on lines
49
to
51
| //recruiter_priority: [number, string][]; | ||
| //recruiter_status: [number, string][]; | ||
| getRecruitmentApplicationStateChoices().then((response) => { |
There was a problem hiding this comment.
Suggested change
| //recruiter_priority: [number, string][]; | |
| //recruiter_status: [number, string][]; | |
| getRecruitmentApplicationStateChoices().then((response) => { | |
| getRecruitmentApplicationStateChoices().then((response) => { |
robines
reviewed
Nov 7, 2024
| @@ -23,21 +24,6 @@ type RecruitmentApplicantsStatusProps = { | |||
| onInterviewChange: () => void; | |||
| }; | |||
|
|
|||
| // TODO add backend to fetch these | |||
| const priorityOptions: DropdownOption<number>[] = [ | |||
There was a problem hiding this comment.
Uenig i at dette er en god løsning. Vi kommer sannsynligvis aldri til å endre recruitment status options, så da er det fullstendig unødvendig å fetche fra backend bare for å populate en dropdown. Det blir ekstremt mange unødvendige api-kall. Mye bedre å bare la det være hardkodet i frontend.
There was a problem hiding this comment.
True, men er mer for sikkerhet at inputtene i frontend og backend matcher.
Er mer sikkert når vi har siden, siden de alternativene alltid vil være like
.
Snorre98
reviewed
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1575