[CfgEditor] Fill .cfg parameters by default values #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamalakhov
force-pushed
the
set_default_BR
branch
2 times, most recently
from
e209415 to
b325949
Compare
seanshpark
reviewed
Feb 8, 2023
seanshpark
reviewed
Feb 8, 2023
stamalakhov
force-pushed
the
set_default_BR
branch
3 times, most recently
from
b21cee9 to
4797076
Compare
dayo09
reviewed
Feb 10, 2023
dayo09
reviewed
Feb 10, 2023
dayo09
requested changes
Feb 10, 2023
src/CfgEditor/CfgEditorPanel.ts
Outdated
Comment on lines
287
to
296
| if (this._activeWebviewPanel === webviewPanel) { | ||
| // there are race conditions with visibility | ||
| // another webviewPanel becomes visible while this one is disposed | ||
| // so 'activeCfgIsVisible' will not be set to false | ||
| vscode.commands.executeCommand( | ||
| "setContext", | ||
| "one.CfgEditor:activeCfgIsVisible", | ||
| false | ||
| ); | ||
| } |
There was a problem hiding this comment.
By using the given context below, you don't need to be bothered to implement this custom context.
"when": "activeCustomEditorId == one.editor.cfg"
There was a problem hiding this comment.
Ahh... Ok. Thank you. I'll try!
dayo09
reviewed
Feb 10, 2023
media/CfgEditor/index.js
Outdated
| @@ -101,6 +104,61 @@ function main() { | |||
| postMessageToVsCode({ type: "requestDisplayCfg" }); | |||
| } | |||
|
|
|||
| function setDefaultValues(name) { | |||
| const optimizationUsed = document.getElementById("checkboxOptimize").checked; | |||
There was a problem hiding this comment.
(Not for functionality, but for readability)
How about collecting related lines?
These optimization-related lines can be moved below, near to the updating lines,
const optimizationUsed = document.getElementById("checkboxOptimize").checked;
let optimizedPath = importedPath + ".opt";
and these quantization-related lines too.
const qType = document.getElementById("DefaultQuantQuantizedDtype").value;
const qSuffix = qType === "uint8" ? ".q8" : ".q16";
let quantizedPath = optimizationUsed
? optimizedPath + qSuffix
: importedPath + qSuffix;
There was a problem hiding this comment.
Thank you. I'll try to make it more clear.
This commit fills .cfg paramters by default values using keyboard shortcut. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
set_default_BR
branch
from
6f15213 to
0955fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fills .cfg paramters by default values using keyboard shortcut.
This commit fills default values in .cfg file (input and output paths for import/optimization/quantization).
Currently its optimal usage would be:
Issue: #1487
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]