Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPQEditor] Improve layout #1548

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stamalakhov
Copy link
Contributor

@stamalakhov stamalakhov commented May 2, 2023

This commit improves UI layout.
This commit improves UI layout.
The draft produces the following UI.

image

Related: #1541
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov requested review from seanshpark and dayo09 May 2, 2023 08:54
@stamalakhov stamalakhov self-assigned this May 2, 2023
@stamalakhov stamalakhov marked this pull request as draft May 2, 2023 08:54
@stamalakhov stamalakhov force-pushed the manual_MPQ_fix_ui_1_br branch from c299da4 to 311c52e Compare May 2, 2023 08:59
@stamalakhov
Copy link
Contributor Author

Also we could place all model nodes AS IS in the table for editing, without default/specific separation.
I mean:

  1. we could populate the table with all models nodes
  2. there are a lot of nodes, so in case we have visq data, we can add additional column with accuracy relevance and then sort all nodes by accuracy relevance so that most erroneous nodes are at the top
  3. in case latency data is available (e.g. profiler output), we can insert another column latency relevance and then sort all nodes by 'latency relevance` to have the ability for fast elimination of slowest nodes as well as the most erroneous nodes
  4. at the bottom of the table we can make summary row, depicting expected 'latency' and accuracy improvements in case MPQ configuration will be applied for quantization

@stamalakhov stamalakhov force-pushed the manual_MPQ_fix_ui_1_br branch 3 times, most recently from 024d4fe to 3f7283a Compare May 18, 2023 09:55
This commit improves UI layout.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_fix_ui_1_br branch from 3f7283a to 5fab92f Compare May 18, 2023 09:58
@stamalakhov
Copy link
Contributor Author

I've changed UI, so now specific layers are contained at scrollable area, so default values are always visible, and also i moved visq controls to the bottom, to make layout more uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant