Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[third_party] Add catapult as git submodule #1613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Aug 8, 2023

This commit adds catapult as submodule to use trace2html.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


Add catapult as a submodule

Why?

I tried to import only the related catapult directories. It exceeded 3000+ lines changes, as can be seen in this PR

For extensibility, it could be better to import the project as a submodule.

Originally posted by @dayo09 in #1611 (comment)

This commit adds catapult as submodule to use trace2html.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 added the DRAFT Something like playground label Aug 8, 2023
@dayo09
Copy link
Contributor Author

dayo09 commented Aug 8, 2023

git submodule update --init --recursive
./third_party/catapult/tracing/bin/trace2html res/samples/traces/sample.timeline.json

@dayo09 dayo09 removed the DRAFT Something like playground label Aug 8, 2023
@dayo09 dayo09 requested a review from a team August 8, 2023 03:09
@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label Aug 8, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team August 8, 2023 05:24
@lemmaa
Copy link
Member

lemmaa commented Aug 8, 2023

@dayo09 , have you checked the license for the cataplut project?
If you want to introduce an external module, it is better to create a separate issue for it, check and organize all matters including the license, and proceed with PR only after taking appropriate measures.

Copy link
Member

@lemmaa lemmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create an issue first!

@jyoungyun
Copy link
Collaborator

When I checked the license of catapult module, this project is BSD-3-Clause license even though the LICENSE file in the catapult-project is Chromium. SOSHub said that we can use this project under the license compliance.

https://opensource.sec.samsung.net/view/search?searchword=Y2F0YXB1bHQ

/cc @lemmaa

@lemmaa
Copy link
Member

lemmaa commented Aug 8, 2023

@jyoungyun , my other concern is when deploying. Actually, this tool should be distributed and used. What kind of package structure will it have then?

@dayo09
Copy link
Contributor Author

dayo09 commented Aug 8, 2023

@lemmaa @jyoungyun I have created the issue to talk about it. :-D

@dayo09 dayo09 changed the title [third_party] Add catapult as submodule [third_party] Add catapult as git submodule Aug 11, 2023
@dayo09 dayo09 added DRAFT Something like playground NO MERGE labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals 2 approvals required to be merged DRAFT Something like playground NO MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants