Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CfgEditor] Check properties existence in loop #1685

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Sep 26, 2023

This commit checks properties' existence in for loop.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


For #1624 (comment)

This commit checks properties' existence in for loop.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 requested a review from a team September 26, 2023 03:54
@dayo09 dayo09 added the 1 approval 1 approval required to be merged label Sep 26, 2023
shs-park
shs-park previously approved these changes Sep 26, 2023
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

media/CfgEditor/index.js Outdated Show resolved Hide resolved
glistening
glistening previously approved these changes Sep 26, 2023
Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayo09 dayo09 dismissed stale reviews from glistening and shs-park via 3485a0e September 26, 2023 04:53
media/CfgEditor/index.js Outdated Show resolved Hide resolved
Co-authored-by: Seungho Henry Park <[email protected]>

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun merged commit 4ba5ba1 into Samsung:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants