Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Alter mocha timeout #1714

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Oct 17, 2023

This commit alter mocha timeout from 2000(default) to 10000 ms. It's to prevent timeout failure during test.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


For #1706

I suspect it as a long latency problem. By rising timeout up to 10000 ms, (default: 2000 ms) the test passes at once. Maybe the CI machine sometime get slower and does not pass within the timeout. They always pass on local machine, so let's simply change the timeout.

This commit alter mocha timeout from 2000(default) to 10000 ms.
It's to prevent timeout failure during test.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 requested a review from stamalakhov October 17, 2023 08:05
@dayo09 dayo09 added the 1 approval 1 approval required to be merged label Oct 17, 2023
@dayo09 dayo09 requested review from a team and removed request for stamalakhov October 17, 2023 08:32
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 3234fd6 into Samsung:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants