Added a SOS Dockerfile script and a README #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidozog
reviewed
Feb 3, 2022
There was a problem hiding this comment.
Looks very useful @kholland-intel - thanks!
I have just a few suggestions/questions.
wrrobin
reviewed
Feb 9, 2022
Fixed README typos, updated working directory to "/home/sos", etc.
davidozog
reviewed
Feb 16, 2022
Added OneAPI binaries to the Dockerfile builder's path for OneAPI compilers
davidozog
approved these changes
Mar 7, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
wrrobin
reviewed
Mar 9, 2022
scripts/docker/README.md
Outdated
| enables the PRRTE Server. | ||
| This is mostly used to run SOS tests when the GNI provider has been enabled in | ||
| the Libfabric build. | ||
| When testing on the GNI provider uncomment out the lines in this portion to |
There was a problem hiding this comment.
It might be better to say the specific line numbers to be uncommented. Same for the previous cases.
There was a problem hiding this comment.
Instead of pointing to a specific line number, I suggested user comment out the code directly under a specific subheading (I felt like the headers were less likely to change than the line numbers). Does this work or do you still prefere that we point them to a specific line number? Examples can be found in the README changes at lines 52 and 73.
wrrobin
approved these changes
Mar 9, 2022
davidozog
reviewed
Mar 21, 2022
davidozog
reviewed
Mar 21, 2022
Also, address grammatical errors in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.