Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manual cache eviction #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

StevenSmiley
Copy link
Collaborator

@StevenSmiley StevenSmiley commented Sep 14, 2024

Issue #, if available: aws#12

Description of changes:

This change adds support for manual cache eviction upon POST request with a secret id.

  • Modify the server to allow POST to the /evict path.
  • Add a function to handle eviction requests.
  • Update the cache manager to support removing a specific entry from the cache.
  • Update relevant tests.

@StevenSmiley
Copy link
Collaborator Author

StevenSmiley commented Sep 14, 2024

On second thought, do we actually need to allow this feature to be disabled through the config? I initially thought that would be nice to support, but now I think we should remove it for simplicity sake. I can't think of situations where it would be important to disable. Another alternative would be to leave the config but set the default to allow.

@StevenSmiley
Copy link
Collaborator Author

On second thought, do we actually need to allow this feature to be disabled through the config? I initially thought that would be nice to support, but now I think we should remove it for simplicity sake. I can't think of situations where it would be important to disable. Another alternative would be to leave the config but set the default to allow.

Decided to remove this config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant