-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING Don't merge] Support DynamicQuantities #2349
Conversation
test/dq_units.jl
Outdated
@test !MT.validate(bad_eqs) | ||
@test !MT.validate(bad_length_eqs) | ||
@named sys = ODESystem(good_eqs, t, [], []) | ||
@test_throws MT.ValidationError ODESystem(bad_eqs, t, [], []; name = :sys) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to pass. It seems it just converts but I presume the codegen doesn't add a convert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently only allow SI units for DQ. The new commit should fix the CI failure.
This reverts commit 1a8b723.
I decided to keep const t = ModelingToolkit.t_dynamic_quantities or const t = ModelingToolkit.t_unitful or const t = ModelingToolkit.t |
I see. Given the direction we're going, I'd propose:
|
To have a nicer syntax, we can have |
Because of SymbolicML/DynamicQuantities.jl#105, we cannot use DQ for the standard library. |
Master is now setup for the v9, no releases till that. |
for posterity, should the |
Just confirming that precompilation was fixed with SymbolicML/DynamicQuantities.jl#106. The compat bound on DynamicQuantities you will want is on |
No description provided.