-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverse Dirichlet Adaptive Loss #504
Open
hpieper14
wants to merge
8
commits into
SciML:master
Choose a base branch
from
hpieper14:inverse-dirichlet-adaptive-loss
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
25f58fc
initialize inverseDirichletAdaptiveLoss as AbstractAdaptiveLoss obj a…
hpieper14 5c95d34
Fix syntax errors
hpieper14 7c3a7a9
Update src/pinns_pde_solve.jl
ChrisRackauckas 0597829
Fix typos, add adaptive reweighting for PDE loss function in addition…
hpieper14 cec87ef
change weight_change_inertia to value from paper
hpieper14 165e3d0
add inverse dirichlet loss to test file
hpieper14 d19fd89
remove epsilon divisor
hpieper14 dabc1d0
pass in generic args
hpieper14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this
reweights_steps
? That's a bit more consistent with the rest of the ecosystemThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose
reweight_every
to be consistent with the variable names chosen forMiniMaxAdaptiveLoss
andGradientScaleAdaptiveLoss
. Is the naming convention isreweight_steps
across other files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
progress_steps
,timeseries_steps
,p_steps
, etc. It's not the biggest deal, but it's slightly more consistent with what else is out there in SciML.