-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better BPINN Log Posterior formulation and Experiments #799
Conversation
@ChrisRackauckas, @Vaibhavdixit02 this has code for both PDE and ODE case over Master Branch. |
What do you mean? There's some conflicts here. |
the extra loss funciton in case of the ODE solver and PDE solver, im still working on the PDE solver case. Ill fix the conflicts as im currently focusing on this pr |
src/training_strategies.jl
Outdated
eq_args = NeuralPDE.get_argument(eqs, dict_indvars, dict_depvars) | ||
# [[:t]] | ||
|
||
points = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type it or create with comprehension
src/training_strategies.jl
Outdated
|
||
points = [] | ||
for eq_arg in eq_args | ||
a = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
I think broadly this looks good already. Do you have any results for comparison of the new likelihood? |
Agreed I look at this and it seems ready-ish to merge. What's the status here? |
Im still running experiments, I've managed to get one test set pass for the new implementation but that's a simple example, the Lorentz equations example fails as I still need to tune the training process better. Overall im working on the new test problems |
Okay sounds good. What do you mean by failing for the Lorenz one, how does it fail? Also Lorenz is way too hard to be the test problem, use the LV instead |
I mean the estimated parameters are not within tolerated error bounds, ive not been able to get HMC or NUTS reduce the Hamiltonian energy enough in all the runs till now. Yeah, will try the same for KS and LV now |
You may want to rebase to master so it should go faster. |
@ChrisRackauckas i apologise for the delayed PR, ive been testing the implementation thoroughly hence the delay(single solve takes 1.5-2hrs). ive shared results uptil now with @Vaibhavdixit02. The results are positive but not significant enough, this is for the LV case as the PDE residual loss is misleading (allows zero gradients trivial solution for inverse problem setting). this PR involves the new loss implementation, some tests, and a correction to the existing PDE BPINN solver(was hidden in the details of the Domain point generation function present in the normal PINN solver). I will add more tests in a seperate PR. |
6ef9d48
to
99a3639
Compare
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Uses extra loss term