-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Training Strategies to dae_solvers.jl #838
Conversation
Added in StochasticTraining strategy for generate_loss function
Added WeightedIntervalTraining
I added the test function for weighted interval training
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have refactoed the generate_loss function for ode_solve. I just merged all the functions into one main function and added the conditional statements to carry out the different tasks based on the abstract type of the strategy.
No, that was not the issue. The issue was to refactor common computations in |
In the previous commit, I merged all the generate_loss function into one function, but I refactored the code incorrectly. I need to refactor each generate loss function between ode_solve and dae_solve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the WeightedIntervalTraining Strategy in dae_solve.jl and the relevant test in NNDAE_test.jl, which the strategy passes. I would like to push that to be merged. My code has been formatted using JuliaFormatter too.
I think we should add rest of the strategies before merging. |
Closing this in favour of #876 |
Added in StochasticTraining strategy for generate_loss function
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.