Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove mutable from ODEPhi struct #864

Closed
wants to merge 2 commits into from
Closed

refactor: remove mutable from ODEPhi struct #864

wants to merge 2 commits into from

Conversation

sathvikbhagavan
Copy link
Member

No description provided.

@sathvikbhagavan
Copy link
Member Author

It is failing making it immutable because st is over written in https://github.com/SciML/NeuralPDE.jl/blob/master/src/ode_solve.jl#L123. st does not make much difference for feed forward networks but it might for other kinds of networks.

@sathvikbhagavan sathvikbhagavan marked this pull request as ready for review June 29, 2024 13:43
@sathvikbhagavan sathvikbhagavan mentioned this pull request Jun 29, 2024
Merged
12 tasks
@avik-pal
Copy link
Member

ODEPhi is no longer mutable

@avik-pal avik-pal closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathvikbhagavan @avik-pal