improved BPINN solvers #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
reviewed
Oct 21, 2024
src/PDE_BPINN.jl
Outdated
|
|
||
| # Dict_differentials is filled with Differential operator => diff_i key-value pairs | ||
| # masking operation | ||
| eqs_new = substitute.(eqs, Ref(Dict_differentials)) |
There was a problem hiding this comment.
use it via SymbolicUtils.substitute else qa tests will fail
|
Its finally ready to be merged, need a final review @avik-pal @ChrisRackauckas |
ChrisRackauckas
approved these changes
Nov 5, 2024
|
Lets goo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
substitute for PR #842