explicit return nothing

SciML · Oct 29, 2024 · ab79a1b · ab79a1b
1 parent 56f4601
commit ab79a1b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/OptimizationMOI/src/nlp.jl b/lib/OptimizationMOI/src/nlp.jl
@@ -309,6 +309,7 @@ function MOI.eval_constraint_jacobian_product(
     else
         error("Thou shalt provide the v'J of the constraint jacobian, not doing so is associated with great misfortune and also no ice cream for you.")
     end
+    return nothing
 end
 
 function MOI.eval_constraint_jacobian_transpose_product(
@@ -326,6 +327,7 @@ function MOI.eval_constraint_jacobian_transpose_product(
     else
         error("Thou shalt provide the v'J of the constraint jacobian, not doing so is associated with great misfortune and also no ice cream for you.")
     end
+    return nothing
 end
 
 function MOI.hessian_lagrangian_structure(evaluator::MOIOptimizationNLPEvaluator)

diff --git a/lib/OptimizationMOI/test/runtests.jl b/lib/OptimizationMOI/test/runtests.jl
@@ -47,14 +47,14 @@ end
     @test (evaluator.f.cons_j !== nothing) || (evaluator.f.cons_jvp !== nothing)
     y = zeros(1)
     w = ones(2)
-    @test MathOptInterface.eval_constraint_jacobian_product(evaluator, y, x, w) isa Any
+    @test MathOptInterface.eval_constraint_jacobian_product(evaluator, y, x, w) === nothing
 
     # constraint jacobian-vector product
     @test (evaluator.f.cons_j !== nothing) || (evaluator.f.cons_vjp !== nothing)
     y = zeros(2)
     w = ones(1)
     @test MathOptInterface.eval_constraint_jacobian_transpose_product(
-        evaluator, y, x, w) isa Any
+        evaluator, y, x, w) === nothing
 end
 
 @testset "NLP" begin