Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OptimizationOptimJL.jl #759

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
Fixes #755

@sjdaines
Copy link
Contributor

sjdaines commented May 22, 2024

Many thanks for fixing this.

However, this addresses #754 (regression in v3.25.0) and does not (yet) address #755 (missing tests) !
(there is no new test yet in this PR...).

Suggested new tests from (now closed) PR #758
https://github.com/SciML/Optimization.jl/blob/764c066948a0e92d5d4c5aeb940b823332212f55/lib/OptimizationOptimJL/test/runtests.jl#L34C5-L38C8

and

https://github.com/SciML/Optimization.jl/blob/764c066948a0e92d5d4c5aeb940b823332212f55/lib/OptimizationOptimJL/test/runtests.jl#L165C5-L181C34

@Vaibhavdixit02 Vaibhavdixit02 merged commit a5d5709 into master May 22, 2024
41 of 43 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the Vaibhavdixit02-patch-1 branch May 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants