Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Optim.BFGS() with user-supplied grad and bounds #761

Merged
merged 1 commit into from
May 26, 2024

Conversation

sjdaines
Copy link
Contributor

Fixes #760 #755

  • add tests for Optim.BFGS() with user-supplied grad and bounds
  • fix wording for error message if bounds specified without either grad function or AD

Checklist

  • [ x] Appropriate tests were added
  • [ x] Any code changes were done in a way that does not break public API
  • [ x] All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [ x] Any new documentation only uses public API

Additional context

See
SciML#760
SciML#755

- add tests for Optim.BFGS() with user-supplied grad and bounds
- fix wording for error message if bounds specified without either grad function or AD
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.06%. Comparing base (e2cad3d) to head (19da423).
Report is 83 commits behind head on master.

Files Patch % Lines
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #761       +/-   ##
==========================================
- Coverage   63.85%   0.06%   -63.79%     
==========================================
  Files          22      22               
  Lines        1527    1605       +78     
==========================================
- Hits          975       1      -974     
- Misses        552    1604     +1052     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 867ef04 into SciML:master May 26, 2024
22 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants