Proposed solution to bug#745 #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment edit needs to be performed in SciMLBase and other solver packages.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 68.51% 0.06% -68.46%
==========================================
Files 22 22
Lines 1607 1613 +6
==========================================
- Hits 1101 1 -1100
- Misses 506 1612 +1106 ☔ View full report in Codecov by Sentry. |
Updated convert function in BBO.
Two functions and a dictionary were added for RetCode handling.
Removed redundant Logging of RetCode types.
Changed convert function name to deduce_retcode and the deduce_retcode function to deduce_retcode_from_string.
Changed the convert function to deduce_retcode for retcode generation.
Retcode function for symbol and string separated.
In the deduce retcode function no need to pass RetCode::T.
Added retcode handling.
Updated the stop_reason_map for the lbfgsb conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.