Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating solver __solve function for MOO #787

Merged
merged 18 commits into from
Aug 19, 2024

Conversation

ParasPuneetSingh
Copy link
Collaborator

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

The _loss function accommodates the MultiObjectiveOptimizationFunction in the __solve method.
Updated loss function in __solve of OptimizationEvolutionary.jl
@Abhinavcode13
Copy link

Abhinavcode13 commented Jul 9, 2024

Any reason for raising this PR, it would be great to know what kind of bug you're trying to fix.
Thanks!

@Vaibhavdixit02
Copy link
Member

@Abhinavcode13 it's a PR, not an issue. The aim is to add support for multiobjective optimization with Evolutionary.jl (for now)

@Abhinavcode13
Copy link

Abhinavcode13 commented Jul 9, 2024

Thanks for pointing it out, but don't it already support one?

@Vaibhavdixit02
Copy link
Member

No

Set the traits for NSGA2 explicitly
Updated the __loss function to handle MOOFunction results.
Added the struct to use BB0_borg_moea.
Exported the new borg_moea struct.
Corrected the loss function check for MultiObjectiveOptimizationFunction.
Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the tests to be pushed to the PR

Added tests for the Multi-Objective Optimization tests to the test set.
Added Multi-Objective Optimization tests to the test set.
Vaibhavdixit02 and others added 4 commits August 16, 2024 16:18
Removed NaNMath, as it wasn't needed.
Added regression tests to the tests for MOO.
Added regression tests for MOO.
@Vaibhavdixit02
Copy link
Member

Evolutionary seems to be failing, it might be a random number seeding issue, when you ran it locally did you run the entire script in the same order?

The regression tests have been updated to solve errors.
ParasPuneetSingh and others added 4 commits August 19, 2024 02:26
The optimize function call updated to handle multi-objective problems.
Added the build_solution alternative call for MOO tests.
Added objective tests for the testset.
@Vaibhavdixit02 Vaibhavdixit02 merged commit c6f9e90 into SciML:master Aug 19, 2024
22 of 25 checks passed
@Vaibhavdixit02
Copy link
Member

Great work @ParasPuneetSingh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants