Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel Surrogate Models Through Ask-tell Interface #435
Parallel Surrogate Models Through Ask-tell Interface #435
Changes from all commits
2eb4353
b31e29c
cd1973c
8528a73
de1f4a3
d114a20
3ad117f
a7c3308
95f8b5a
48d4601
6c4a393
1b27538
837002d
7c23984
bcc5451
ea4eef2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Check warning on line 387 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L387
Check warning on line 392 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L390-L392
Check warning on line 394 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L394
Check warning on line 400 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L397-L400
Check warning on line 403 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L402-L403
Check warning on line 408 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L405-L408
Check warning on line 412 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L410-L412
Check warning on line 414 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L414
Check warning on line 422 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L416-L422
Check warning on line 430 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L424-L430
Check warning on line 433 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L432-L433
Check warning on line 436 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L435-L436
Check warning on line 438 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L438
Check warning on line 442 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L441-L442
Check warning on line 446 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L444-L446
Check warning on line 448 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L448
Check warning on line 452 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L451-L452
Check warning on line 455 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L455
Check warning on line 459 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L457-L459
Check warning on line 464 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L461-L464
Check warning on line 466 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L466
Check warning on line 470 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L469-L470
Check warning on line 475 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L472-L475
Check warning on line 480 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L478-L480
Check warning on line 483 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L483
Check warning on line 488 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L487-L488
Check warning on line 490 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L490
Check warning on line 494 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L494
Check warning on line 500 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L497-L500
Check warning on line 502 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L502
Check warning on line 508 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L504-L508
Check warning on line 511 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L511
Check warning on line 516 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L513-L516
Check warning on line 519 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L518-L519
Check warning on line 522 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L522
Check warning on line 530 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L525-L530
Check warning on line 538 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L532-L538
Check warning on line 541 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L540-L541
Check warning on line 544 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L543-L544
Check warning on line 548 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L546-L548
Check warning on line 551 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L551
Check warning on line 554 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L554
Check warning on line 557 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L557
Check warning on line 563 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L561-L563
Check warning on line 566 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L565-L566
Check warning on line 568 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L568
Check warning on line 574 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L570-L574
Check warning on line 580 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L578-L580
Check warning on line 583 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L583
Check warning on line 588 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L587-L588
Check warning on line 590 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L590
Check warning on line 789 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L789
Check warning on line 793 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L792-L793
Check warning on line 796 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L795-L796
Check warning on line 798 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be pretty heavy. Did you check it did not cause a significant performance issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tests and it seems like in all cases,
deepcopy
will never be anywhere close to your bottleneck. The bottleneck is always either evaluating your objective function or calculating the expected improvement or merit function.Check warning on line 801 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L800-L801
Check warning on line 803 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L803
Check warning on line 805 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L805
Check warning on line 808 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L808
Check warning on line 813 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L811-L813
Check warning on line 819 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L815-L819
Check warning on line 821 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L821
Check warning on line 824 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L824
Check warning on line 826 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L826
Check warning on line 832 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L828-L832
Check warning on line 834 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L834
Check warning on line 841 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L836-L841
Check warning on line 847 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L844-L847
Check warning on line 850 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L849-L850
Check warning on line 852 in src/Optimization.jl
Codecov / codecov/patch
src/Optimization.jl#L852