Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI #458

Merged
merged 4 commits into from
Dec 28, 2023
Merged

More CI #458

merged 4 commits into from
Dec 28, 2023

Conversation

ArnoStrouwen
Copy link
Member

@ChrisRackauckas
Copy link
Member

Define an _copy function and use it in that file.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa744e5) 78.12% compared to head (3fd8d0b) 78.12%.

Files Patch % Lines
src/Radials.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files          23       23           
  Lines        3154     3155    +1     
=======================================
+ Hits         2464     2465    +1     
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArnoStrouwen
Copy link
Member Author

I was hoping that with the standard libraries compat changes it would be possible to run CI on Julia 1.10 with e.g. LinearAlgebra on 1.9, but this seems not to be the case:
https://github.com/SciML/Surrogates.jl/actions/runs/7348928232/job/20007931762?pr=458#step:5:47
@ChrisRackauckas how do you want to handle downgrade CI then? Either we bump everything to 1.10, or we ignore the standard libraries.

@ChrisRackauckas
Copy link
Member

I want to bump all libraries and CI to v1.10. I guess we can start here.

@ArnoStrouwen
Copy link
Member Author

The downgrade CI is already bearing fruits, it found that in Julia 1.10 you need the very recent Zygote = "0.6.62".

@ChrisRackauckas ChrisRackauckas merged commit 1cff140 into SciML:master Dec 28, 2023
7 of 8 checks passed
@ArnoStrouwen ArnoStrouwen deleted the ci branch December 29, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants