Merge pull request #1661 from Scille/fix-flaky-test_delete_invitation…

…_while_claimer_connected Fix flaky beavior in test_delete_invitation_while_claimer_connected
Scille · Mar 17, 2021 · 78eb978 · 78eb978
2 parents cfbec62 + e73245c
commit 78eb978
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/newsfragments/1661.empty.rst b/newsfragments/1661.empty.rst
diff --git a/tests/backend/invite/test_base.py b/tests/backend/invite/test_base.py
@@ -521,14 +521,14 @@ async def test_delete_invitation_while_claimer_connected(
     async with backend_invited_sock_factory(
         backend,
         organization_id=alice.organization_id,
-        invitation_type=InvitationType.USER,
+        invitation_type=invitation.TYPE,
         token=invitation.token,
         freeze_on_transport_error=False,
     ) as invited_sock:
         async with backend_invited_sock_factory(
             backend,
             organization_id=alice.organization_id,
-            invitation_type=InvitationType.USER,
+            invitation_type=other_invitation.TYPE,
             token=other_invitation.token,
             freeze_on_transport_error=False,
         ) as other_invited_sock:
@@ -547,7 +547,10 @@ async def test_delete_invitation_while_claimer_connected(
                     # Claimer connection can take some time to be closed
                     while True:
                         rep = await invite_info(invited_sock)
-                        assert rep == {"status": "already_deleted"}
+                        # Invitation info are cached for the connection
+                        # at handshake time, hence if the command won't take
+                        # into account the fact the invitation has been deleted
+                        assert rep["status"] == "ok"
 
             # However other invitations shouldn't have been affected
             rep = await invite_info(other_invited_sock)