Skip to content

Commit

Permalink
Fix uploading snap to multiple channels
Browse files Browse the repository at this point in the history
Currently only the latest args `--release` is used by snapcraft for upload.
  • Loading branch information
FirelightFlagboy committed Jul 24, 2024
1 parent 8bad1b5 commit 7a54264
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,15 @@ jobs:
timeout-minutes: 2

- name: Upload Snap
run: snapcraft upload $(cat ${{ runner.temp }}/snap-releases-args) snap/Parsec_${{ steps.version.outputs.full }}_linux_*.snap
run: |
set -x
for channel_arg in $(cat ${{ runner.temp }}/snap-releases-args); do
snapcraft upload $channel_arg snap/Parsec_${{ steps.version.outputs.full }}_linux_*.snap
done
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_CREDENTIALS }}
timeout-minutes: 5
# Each upload take ~2min, we could have up to 4 channel to upload so: `2 * 4 = 8min` (plus a little spare)
timeout-minutes: 10

- name: Publish wheel on PyPI
uses: pypa/gh-action-pypi-publish@ec4db0b4ddc65acdf4bff5fa45ac92d78b56bdf0 # pin v1.9.0
Expand Down

0 comments on commit 7a54264

Please sign in to comment.