Specify shell in all GitHub Actions workflows when needed #8648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
fix-clippy
branch
from
9625541 to
0e5bfd5
Compare
FirelightFlagboy
force-pushed
the
fix-clippy
branch
from
0e5bfd5 to
b7455b0
Compare
FirelightFlagboy
force-pushed
the
fix-clippy
branch
2 times, most recently
from
b9c0758 to
5f18b2c
Compare
Summary ------- - `shell: bash` was added when a run command used pipes (including command that used `set -e -o pipefail`). For the documentation: <https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference> Setting `shell` to that value will automatically add the `-o pipefail` (alongside `-e`) - `shell: bash ... {0}` was used for run commands that used `set ...` Fixes ----- - Fix `yq` syntax (GA use `yq-go` not `yq` (the python wrapper of `jq`)) - Fix clippy error in `libparsec/crates/platform_device_loader/tests/archive.rs`
FirelightFlagboy
force-pushed
the
fix-clippy
branch
from
5f18b2c to
465a392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
shell: bashwas added when a run command used pipes (including command that usedset -e -o pipefail).For the documentation: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
Setting
shellto that value will automatically add the-o pipefail(alongside-e)shell: bash ... {0}was used for run commands that usedset ...Fixes
yqsyntax (GA useyq-gonotyq(the python wrapper ofjq))